This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngTouch): prevent touchmove from canceling a click #11359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually browsers fire touchstart and touchend, and ng-click works. But some browsers (I only experienced it on iOS) fire touchmove between touchstart and touchend, and so before this fix ng-click would not work in this case. Also, the test for touchmove was incorrect: it did not test the touchmove event itself, but rather the coordinates change, which is handled elsewhere. If the coordinates are the same and the interval is not too long, ng-click should fire, no matter if there was a touchmove or not.
|
Hi @pomerantsev - this is a duplicate of #10985 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually browsers fire touchstart and touchend, and ng-click works.
But some browsers (I only experienced it on iOS) fire touchmove
between touchstart and touchend, and so before this fix ng-click
would not work in this case.
Also, the test for touchmove was incorrect: it did not test
the touchmove event itself, but rather the coordinates change,
which is handled elsewhere. If the coordinates are the same and
the interval is not too long, ng-click should fire, no matter if
there was a touchmove or not.